Apache MINA 2.2.X update #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-thing
commented
May 13, 2023
quickfixj-core/src/main/java/quickfix/mina/initiator/InitiatorProxyIoHandler.java
Outdated
Show resolved
Hide resolved
the-thing
commented
May 13, 2023
the-thing
commented
May 13, 2023
the-thing
commented
May 13, 2023
|
Thanks for the PR. I'm more comfortable merging your PR than mine since you have more experience in SSL and MINA internals than me. |
chrjohn
reviewed
May 15, 2023
There was a problem hiding this comment.
Could you please also update https://github.com/quickfix-j/quickfixj/blob/master/quickfixj-core/src/main/doc/usermanual/usage/configuration.html with the new configuration and remove the old UseSNI config? Thank you.
Closed
chrjohn
reviewed
May 15, 2023
MINA 2.2.2 has been released.
chrjohn
approved these changes
Jun 7, 2023
|
@masonedmison did you test that it works with this change.? |
This was referenced Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #634
Attempt to update MINA
I had a look at the branch - #441, but it was slightly behind the master so I decided to do it from scratch on master. Feel free not to merge this pull requires if you want to apply similar changes to the other branch.
I was able to improve and remove some of the SSL code including cipher suites config and the temporary useSNI flag etc. Test cases for SNI were also added.
I'm not sure about the proxy code. The problem with proxy is that there are no tests for it so we don't know if we are breaking things or fixing them. I think it is crucial to add some embedded proxy server at some point and make sure that it works.