Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 32bit limbs for BigInt implementation #1008

Merged
merged 2 commits into from
Apr 3, 2025
Merged

Use 32bit limbs for BigInt implementation #1008

merged 2 commits into from
Apr 3, 2025

Conversation

saghul
Copy link
Contributor

@saghul saghul commented Apr 3, 2025

It's simpler and compatible with all platforms.

@saghul
Use 32bit limbs for BigInt implementation
0b1ba3e 
It's simpler and compatible with all platforms.
saghul
saghul commented Apr 3, 2025
View reviewed changes
@saghul
Copy link
Contributor Author

saghul commented Apr 3, 2025

It thinks there is a leak :-/

./build/qjs -D0x4000 -I test262/harness/assert.js test262/test/language/expressions/unary-plus/bigint-throws.js
Memory leak: 16 bytes lost in 1 block

@saghul saghul requested a review from bnoordhuis April 3, 2025 08:19
@saghul saghul marked this pull request as ready for review April 3, 2025 08:19
bnoordhuis
bnoordhuis approved these changes Apr 3, 2025
View reviewed changes
@saghul saghul merged commit 68d4017 into master Apr 3, 2025
238 of 239 checks passed
@saghul saghul deleted the simplify-bigint branch April 3, 2025 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saghul @bnoordhuis