Skip to content

Commit

Permalink
CR comment
Browse files Browse the repository at this point in the history
  • Loading branch information
fulmicoton committed Mar 7, 2024
1 parent 9f5f049 commit 094d986
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions chitchat/src/delta.rs
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ impl TryFrom<u8> for DeltaOpTag {
match tag_byte {
0u8 => Ok(DeltaOpTag::Node),
1u8 => Ok(DeltaOpTag::KeyValue),
2u8 => Ok(DeltaOpTag::SetMaxVersion),
_ => {
anyhow::bail!("Unknown tag: {tag_byte}")
}
Expand Down Expand Up @@ -297,10 +298,10 @@ impl Delta {
#[derive(Debug, Eq, PartialEq, serde::Serialize)]
pub(crate) struct NodeDelta {
pub chitchat_id: ChitchatId,
// `from_version` and `last_gc_version` are here to express on which states
// `from_version_excluded` and `last_gc_version` are here to express on which states
// this delta can be applied to.
//
// `last_gc_version` expresses that this delta has be computed from a state where no
// `last_gc_version` expresses that this delta was computed from a state where no
// keys > `last_gc_version` have been removed.
//
// `from_version` expresses that from this state, ALL of the records in
Expand Down Expand Up @@ -732,6 +733,6 @@ mod tests {
num_valid_tags += 1;
}
}
assert_eq!(num_valid_tags, 2);
assert_eq!(num_valid_tags, 3);
}
}

0 comments on commit 094d986

Please sign in to comment.