Change in the liveness detection. #116
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fulmicoton
commented
Feb 15, 2024
fulmicoton
commented
- Updating heartbeat on Digest messages (in addition to process delta)
- Avoid making up an interval when we have received a single heartbeat.
- Never marking nodes with less than 2 heartbeat recorded as live.
- Using additive smoothing to deal with the problem of the inability to assess liveness on the first few samples.
fulmicoton
force-pushed
the
leveraging-digest
branch
from
8b22dd6 to
b2e7bb1
Compare
fulmicoton
commented
Feb 15, 2024
| } | ||
|
|
||
| /// Appends a new value and updates the statistics. | ||
| pub fn append(&mut self, interval: f64) { | ||
| if self.index == self.size { |
There was a problem hiding this comment.
I really dislike this kind of code because it is impossible to put a meaning to self.index.
fulmicoton
force-pushed
the
leveraging-digest
branch
2 times, most recently
from
ce8e1c0 to
97325d9
Compare
- Updating heartbeat on Digest messages (in addition to process delta) - Avoid making up an interval when we have received a single heartbeat. - Never marking nodes with less than 2 heartbeat recorded as live. - Using additive smoothing to deal with the problem of the inability to assess liveness on the first few samples. - light refactoring.
fulmicoton
force-pushed
the
leveraging-digest
branch
from
97325d9 to
b0cd849
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.