Key deletion logic bugfix #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulmicoton
force-pushed
the
issue/121-delete-key-gc
branch
3 times, most recently
from
013c00c to
09b82d4
Compare
fulmicoton
force-pushed
the
issue/121-delete-key-gc
branch
from
09b82d4 to
d729b26
Compare
fulmicoton
commented
Feb 19, 2024
| marked_for_deletion_grace_period: u64, | ||
| dead_nodes: &HashSet<ChitchatId>, | ||
| ) { | ||
| for (chitchat_id, node_state) in &mut self.node_states { |
There was a problem hiding this comment.
No clue why we skipped dead nodes in GC.
fmassot
reviewed
Feb 19, 2024
fmassot
reviewed
Feb 19, 2024
fulmicoton
added a commit
that referenced
this pull request
Feb 19, 2024
detection. Right now we send the heartbeat of all of the known nodes in the cluster during digests. We can use that information for cluster membership. This will allow nodes to detect new member, join a cluster, and detect failure considerably faster. This PR also removes heartbeat from delta message. Instead it joins the last_gc_version, to fix a bug introduced in #122.
fulmicoton
added a commit
that referenced
this pull request
Feb 19, 2024
Right now we send the heartbeat of all of the known nodes in the cluster during digests. We can use that information for cluster membership. This will allow nodes to detect new member, join a cluster, and detect failure considerably faster. This PR also removes heartbeat from delta message. Instead it joins the last_gc_version, to fix a bug introduced in #122.
fulmicoton
added a commit
that referenced
this pull request
Feb 19, 2024
Right now we send the heartbeat of all of the known nodes in the cluster during digests. We can use that information for cluster membership. This will allow nodes to detect new member, join a cluster, and detect failure considerably faster. This PR also removes heartbeat from delta message. Instead it joins the last_gc_version, to fix a bug introduced in #122.
fmassot
reviewed
Feb 19, 2024
fulmicoton
added a commit
that referenced
this pull request
Feb 19, 2024
Right now we send the heartbeat of all of the known nodes in the cluster during digests. We can use that information for cluster membership. This will allow nodes to detect new member, join a cluster, and detect failure considerably faster. This PR also removes heartbeat from delta message. Instead it joins the last_gc_version, to fix a bug introduced in #122. Bugfix: Avoid updating the time of death of a node when it is redetected as faulty. We remove outselves from the list of seeds. Before nodes were regularly gossipping with themselves. Code improvement: In the failure detector when we have few samples. We now use additive smoothing.
fulmicoton
added a commit
that referenced
this pull request
Feb 19, 2024
Right now we send the heartbeat of all of the known nodes in the cluster during digests. We can use that information for cluster membership. This will allow nodes to detect new member, join a cluster, and detect failure considerably faster. This PR also removes heartbeat from delta message. Instead it joins the last_gc_version, to fix a bug introduced in #122. Bugfix: Avoid updating the time of death of a node when it is redetected as faulty. We remove outselves from the list of seeds. Before nodes were regularly gossipping with themselves. Code improvement: In the failure detector when we have few samples. We now use additive smoothing.
fmassot
reviewed
Feb 19, 2024
chitchat/src/configuration.rs
Outdated
| @@ -56,7 +56,8 @@ impl Default for ChitchatConfig { | |||
| failure_detector_config: Default::default(), | |||
| // Each heartbeat increments the version, with one heartbeat each second | |||
| // 86400 ~ 24h. | |||
| marked_for_deletion_grace_period: 86400, | |||
| // TODO set that to something much lower. | |||
There was a problem hiding this comment.
let's do it, something like 1 or 2 hours?
fmassot
approved these changes
Feb 19, 2024
fulmicoton
force-pushed
the
issue/121-delete-key-gc
branch
from
9024812 to
c8c363c
Compare
fulmicoton
added a commit
that referenced
this pull request
Feb 19, 2024
Right now we send the heartbeat of all of the known nodes in the cluster during digests. We can use that information for cluster membership. This will allow nodes to detect new member, join a cluster, and detect failure considerably faster. This PR also removes heartbeat from delta message. Instead it joins the last_gc_version, to fix a bug introduced in #122. Bugfix: Avoid updating the time of death of a node when it is redetected as faulty. We remove outselves from the list of seeds. Before nodes were regularly gossipping with themselves. Code improvement: In the failure detector when we have few samples. We now use additive smoothing.
fulmicoton
added a commit
that referenced
this pull request
Feb 19, 2024
Right now we send the heartbeat of all of the known nodes in the cluster during digests. We can use that information for cluster membership. This will allow nodes to detect new member, join a cluster, and detect failure considerably faster. This PR also removes heartbeat from delta message. Instead it joins the last_gc_version, to fix a bug introduced in #122. Bugfix: Avoid updating the time of death of a node when it is redetected as faulty. We remove outselves from the list of seeds. Before nodes were regularly gossipping with themselves. Code improvement: In the failure detector when we have few samples. We now use additive smoothing.
fulmicoton
added a commit
that referenced
this pull request
Feb 19, 2024
Right now we send the heartbeat of all of the known nodes in the cluster during digests. We can use that information for cluster membership. This will allow nodes to detect new member, join a cluster, and detect failure considerably faster. This PR also removes heartbeat from delta message. Instead it joins the last_gc_version, to fix a bug introduced in #122. Bugfix: Avoid updating the time of death of a node when it is redetected as faulty. We remove outselves from the list of seeds. Before nodes were regularly gossipping with themselves. Code improvement: In the failure detector when we have few samples. We now use additive smoothing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #121