Added a way to set a TTL to key values. #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chitchat/src/state.rs
Outdated
| { | ||
| let versioned_value = node_state.get_versioned("key").unwrap(); | ||
| assert_eq!(&versioned_value.value, ""); | ||
| assert_eq!(versioned_value.version, 2u64); | ||
| assert!(&versioned_value.is_tombstone()); | ||
| assert!(&versioned_value.is_deleted()); |
There was a problem hiding this comment.
Suggested change
| assert!(&versioned_value.is_deleted()); | |
| assert!(versioned_value.is_deleted()); |
i don't think the borrow is necessary, and i find it somewhat confusing (is it supposed to be a borrow, or a mistyped !)
There was a problem hiding this comment.
yes, I find it confusing too.
chitchat/src/types.rs
Outdated
| @@ -108,7 +133,7 @@ impl PartialEq for VersionedValue { | |||
| fn eq(&self, other: &Self) -> bool { | |||
| self.value.eq(&other.value) | |||
| && self.version.eq(&other.version) | |||
| && self.is_tombstone().eq(&other.is_tombstone()) | |||
| && self.is_deleted().eq(&other.is_deleted()) | |||
There was a problem hiding this comment.
I'm not sure is_deleted is enough to qualify equality. DeletionStatus::Set and DeletionStatus::DeleteAfterTtl are considered equal by this statement. If that is intended, a comment should explain why
There was a problem hiding this comment.
Thx. I switched to checking the discriminant, added a comment, and made PartialEq cfg test only.
After the GC grace period, the key value will be subject to the GC just like regularly deleted KVs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the GC grace period, the key value will be subject to the GC just like regularly deleted KVs.