Change in the liveness detection.
clippy
6 errors
Details
Results
| Message level | Amount |
|---|---|
| Internal compiler error | 0 |
| Error | 6 |
| Warning | 0 |
| Note | 0 |
| Help | 0 |
Versions
- rustc 1.76.0 (07dca489a 2024-02-04)
- cargo 1.76.0 (c84b36747 2024-01-18)
- clippy 0.1.76 (07dca48 2024-02-04)
Annotations
Check failure on line 176 in chitchat/src/lib.rs
github-actions / clippy
this expression creates a reference which is immediately dereferenced by the compiler
error: this expression creates a reference which is immediately dereferenced by the compiler
--> chitchat/src/lib.rs:176:52
|
176 | self.failure_detector.report_heartbeat(&chitchat_id);
| ^^^^^^^^^^^^ help: change this to: `chitchat_id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Check failure on line 101 in chitchat/src/lib.rs
github-actions / clippy
this expression creates a reference which is immediately dereferenced by the compiler
error: this expression creates a reference which is immediately dereferenced by the compiler
--> chitchat/src/lib.rs:101:35
|
101 | self.report_heartbeat(&chitchat_id, node_digest.heartbeat);
| ^^^^^^^^^^^^ help: change this to: `chitchat_id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `-D clippy::needless-borrow` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]`
Check failure on line 176 in chitchat/src/lib.rs
github-actions / clippy
this expression creates a reference which is immediately dereferenced by the compiler
error: this expression creates a reference which is immediately dereferenced by the compiler
--> chitchat/src/lib.rs:176:52
|
176 | self.failure_detector.report_heartbeat(&chitchat_id);
| ^^^^^^^^^^^^ help: change this to: `chitchat_id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Check failure on line 101 in chitchat/src/lib.rs
github-actions / clippy
this expression creates a reference which is immediately dereferenced by the compiler
error: this expression creates a reference which is immediately dereferenced by the compiler
--> chitchat/src/lib.rs:101:35
|
101 | self.report_heartbeat(&chitchat_id, node_digest.heartbeat);
| ^^^^^^^^^^^^ help: change this to: `chitchat_id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `-D clippy::needless-borrow` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]`
Check failure on line 269 in chitchat/src/failure_detector.rs
github-actions / clippy
manual implementation of an assign operation
error: manual implementation of an assign operation
--> chitchat/src/failure_detector.rs:269:9
|
269 | self.index = self.index + 1;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.index += 1`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
= note: `-D clippy::assign-op-pattern` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::assign_op_pattern)]`
Check failure on line 269 in chitchat/src/failure_detector.rs
github-actions / clippy
manual implementation of an assign operation
error: manual implementation of an assign operation
--> chitchat/src/failure_detector.rs:269:9
|
269 | self.index = self.index + 1;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.index += 1`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
= note: `-D clippy::assign-op-pattern` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::assign_op_pattern)]`