Removing async from mrecordlog. #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulmicoton
force-pushed
the
issue/52-mrecordlog-corruption
branch
2 times, most recently
from
e44d331 to
4ef47d2
Compare
fulmicoton
force-pushed
the
issue/52-mrecordlog-corruption
branch
from
4ef47d2 to
a4d25c9
Compare
fulmicoton
changed the title
trinity-1686a
approved these changes
Feb 29, 2024
fulmicoton
force-pushed
the
issue/52-mrecordlog-corruption
branch
from
cef55ae to
40c3d4e
Compare
fulmicoton
force-pushed
the
issue/52-mrecordlog-corruption
branch
from
40c3d4e to
0c35d3c
Compare
RaphaelMarinier
added a commit
that referenced
this pull request
Mar 11, 2024
Deserializing the contents of a MultiPlexedRecords could panic instead of returning an error when the buffer was truncated. Added tests for that (and also for a similar deserialization bug for MultiRecord fixed in #53).
RaphaelMarinier
added a commit
that referenced
this pull request
Mar 11, 2024
Deserializing the contents of a MultiRecord could panic instead of returning an error when the buffer was truncated. Added tests for that (and also for a similar deserialization bug for MultiPlexedRecords fixed in #53).
fulmicoton
pushed a commit
that referenced
this pull request
Mar 22, 2024
…g. (#56) * Fix a small bug in deserialization: return errors instead of panicking. Deserializing the contents of a MultiRecord could panic instead of returning an error when the buffer was truncated. Added tests for that (and also for a similar deserialization bug for MultiPlexedRecords fixed in #53). * formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.