Fulmicoton fsync data #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upon critical situation we flush and fsync.
fulmicoton
force-pushed
the
fulmicoton--fsync-data
branch
from
ab1d289 to
1d3b2ae
Compare
trinity-1686a
approved these changes
Mar 22, 2024
src/multi_record_log.rs
Outdated
| impl MultiRecordLog { | ||
| /// Open the multi record log, syncing after each operation. | ||
| /// Open the multi record log, flushing after each operation, bit not fsyncing. |
There was a problem hiding this comment.
typo
Suggested change
| /// Open the multi record log, flushing after each operation, bit not fsyncing. | |
| /// Open the multi record log, flushing after each operation, but not fsyncing. |
Comment on lines
+20
to
+22
| /// Critical records are relatively rare and really need to be persisted: | ||
| /// - RecordPosition { queue: &'a str, position: u64 }, | ||
| /// - DeleteQueue. |
There was a problem hiding this comment.
CreateQueue is a bit of a virtual operation, but I think it's worth putting it in that list
There was a problem hiding this comment.
It is not that virtual but yeah, it should not be consequential for Quickwit.
This was referenced Mar 28, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.