Rework command for adding a new source to an indexing #1270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilload
force-pushed
the
guilload--#1071--rework-source-add-command
branch
from
67dd3a8 to
34eb196
Compare
guilload
commented
Apr 8, 2022
fulmicoton
reviewed
Apr 11, 2022
fulmicoton
approved these changes
Apr 11, 2022
guilload
force-pushed
the
guilload--#1071--rework-source-add-command
branch
from
34eb196 to
9e66ae1
Compare
fmassot
reviewed
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The new command is
quickwit source create --index my-index --source-config my-source-config.yaml. As we may revisit how me manage objects in a near future (#1024), I chose to leave the index out of the config so I did not have to write some custom parsing logic.Fixes #1071
How was this PR tested?
make test-all