Removed metastore -> controlplane event flow via the EventBroker. #3880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulmicoton
force-pushed
the
complete_control_plane_metastore
branch
3 times, most recently
from
2c24467 to
7bd76eb
Compare
fulmicoton
commented
Oct 4, 2023
fulmicoton
force-pushed
the
complete_control_plane_metastore
branch
2 times, most recently
from
ba4f319 to
6ec7a6c
Compare
The two internal actors are replaced by two internal states. Their execution is not concurrent anymore, but we the code and the flow is simplified and we avoid some race conditions. The control plane is not getting the update notify signal through the broker anymore. The Notify RPC is entirely removed. Most of the test in the indexer scheduler become Control plane tests.
fulmicoton
force-pushed
the
complete_control_plane_metastore
branch
from
6ec7a6c to
05ee6ed
Compare
guilload
approved these changes
Oct 4, 2023
| Ok(Ok(response)) | ||
| Ok(self | ||
| .ingest_controller | ||
| .get_open_shards(request, ctx.progress()) |
There was a problem hiding this comment.
I've renamed this event GetOrCreateOpenShardsRequest to make it clear that it may create new shards. When it does, the indexing scheduler should be notified.
| /// Subscribes to various metastore events and forwards them to the control plane using the inner | ||
| /// client. The actual subscriptions are set up in `quickwit-serve`. | ||
| #[derive(Debug, Clone)] | ||
| pub struct ControlPlaneEventSubscriber(ControlPlaneServiceClient); |
There was a problem hiding this comment.
Arg. I'm adding two callbacks in my PR :D
There was a problem hiding this comment.
We can readd whatever is needed.
I think it was never plugged. |
fulmicoton
force-pushed
the
complete_control_plane_metastore
branch
from
cdd98ea to
9b8ce21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring of the control plane.
The two internal actors are replaced by two internal states.
Their execution is not concurrent anymore,
but we the code and the flow is simplified and we avoid some race conditions.
The control plane is not getting the update notify signal through the
broker anymore.
The Notify RPC is entirely removed.
Most of the test in the indexer scheduler become Control plane tests.