Removing ambiguity between the different ways to create an IndexUid. #4038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulmicoton
force-pushed
the
issue/3943-index-uid-b
branch
2 times, most recently
from
fee5726 to
b5a2c05
Compare
guilload
approved these changes
Oct 27, 2023
fulmicoton
force-pushed
the
issue/3943-index-uid-b
branch
from
b5a2c05 to
e92942f
Compare
The code will now panic if the arguments are wrong. Ideally we would prefer to have a TryFrom implementation. Before this PR, some client argument could silently create an IndexUi thatwere breaking a contract (IndexUid wrapping a string without a ":k"). After this PR, some client argument could create a panic. This partly addresses to #3943.
fulmicoton
force-pushed
the
issue/3943-index-uid-b
branch
from
e92942f to
814cb3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code will now panic if the arguments are wrong.
Ideally we would prefer to have a TryFrom implementation.
Before this PR, some client argument could silently create an IndexUi thatwere breaking a contract (IndexUid wrapping a string without a ":k").
After this PR, some client argument could create a panic.
This partly addresses to #3943.