Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix #4042 - An index ptn not matching any index is ok. #4048

Merged
merged 8 commits into from
Oct 30, 2023
Merged

Bugfix #4042 - An index ptn not matching any index is ok. #4048

merged 8 commits into from
Oct 30, 2023

Conversation

fulmicoton
Copy link
Contributor

@fulmicoton fulmicoton commented Oct 29, 2023 •
edited
Loading

Fixes #4042

Tested with rest integration tests (checked against elasticsearch)

@fulmicoton
Added rest integraton test to test the behavior
c199d05 
when facing patterns not matching any indexes.

Related with #4042
@fulmicoton fulmicoton mentioned this pull request Oct 29, 2023
Closed
@fulmicoton fulmicoton force-pushed the issue/4042-no-index-match branch 2 times, most recently from d255930 to 374ebf9 Compare October 29, 2023 03:34
@fulmicoton fulmicoton requested a review from fmassot October 29, 2023 03:34
@fulmicoton fulmicoton changed the title Added rest integraton test to test the behavior Bugfix #4042 - An index ptn not matching any index is ok. Oct 29, 2023
@fulmicoton fulmicoton force-pushed the issue/4042-no-index-match branch from 374ebf9 to c9defea Compare October 29, 2023 03:41
@fulmicoton fulmicoton force-pushed the issue/4042-no-index-match branch from c9defea to 192fa48 Compare October 29, 2023 04:01
fmassot
fmassot approved these changes Oct 29, 2023
View reviewed changes
Copy link
Contributor

@fmassot fmassot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you have a look at the 2 minor comments?

@fulmicoton fulmicoton enabled auto-merge (squash) October 30, 2023 02:10
@fulmicoton fulmicoton disabled auto-merge October 30, 2023 02:21
@fulmicoton fulmicoton merged commit 601c231 into main Oct 30, 2023
3 checks passed
@fulmicoton fulmicoton deleted the issue/4042-no-index-match branch October 30, 2023 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmassot fmassot fmassot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Elasticsearch compatible search endpoint should return an empty set when no matching index is found
2 participants
@fulmicoton @fmassot