Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added an integration test for ingest v2 #4071

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Added an integration test for ingest v2 #4071

merged 2 commits into from
Nov 10, 2023

Conversation

fulmicoton
Copy link
Contributor

@fulmicoton fulmicoton commented Nov 2, 2023 •
edited
Loading

(We might want to fix #4070 before merging)

@fulmicoton fulmicoton marked this pull request as ready for review November 2, 2023 03:08
@fulmicoton fulmicoton requested a review from guilload November 2, 2023 03:13
@fulmicoton fulmicoton force-pushed the integration-tests2 branch 4 times, most recently from 728f837 to 1e265da Compare November 8, 2023 10:07
@fulmicoton fulmicoton requested review from fmassot and removed request for guilload November 8, 2023 10:08
@fulmicoton fulmicoton force-pushed the integration-tests2 branch 2 times, most recently from 3366d15 to 0b99bba Compare November 10, 2023 12:40
@fulmicoton
Added an integration test for ingest v2
fec02ba 
- Adds an ingest_v2 method to the cluster sandbox.
- Adds two simple integration tests.
- Converts the ingest v2 error into rest api errors.
- This PR suffers from the deadlock described in #4070

Closes #4065
@fulmicoton fulmicoton merged commit 9e95ec9 into main Nov 10, 2023
1 check passed
@fulmicoton fulmicoton deleted the integration-tests2 branch November 10, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmassot fmassot fmassot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deadlock in fetch ingest v2
2 participants
@fulmicoton @fmassot