Implement ingester graceful shutdown #4117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilload
force-pushed
the
guilload/ingester-graceful-shutdown
branch
from
0e1a943 to
c99cc96
Compare
guilload
force-pushed
the
guilload/ingester-graceful-shutdown
branch
2 times, most recently
from
4c64ebf to
b5a507e
Compare
fulmicoton
reviewed
Nov 14, 2023
fulmicoton
reviewed
Nov 14, 2023
fulmicoton
reviewed
Nov 14, 2023
fulmicoton
reviewed
Nov 14, 2023
fulmicoton
approved these changes
Nov 14, 2023
fulmicoton
reviewed
Nov 14, 2023
guilload
force-pushed
the
guilload/ingester-graceful-shutdown
branch
2 times, most recently
from
8916fb5 to
9697a4e
Compare
guilload
force-pushed
the
guilload/ingester-graceful-shutdown
branch
from
9697a4e to
727e9a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a
DecommissionRPC to ingesters. By default, ingesters are inReadystatus. Upon receiving a decommissioning request, ingesters change their status toDecommissioning, close all their shards, become read-only and wait for them to be indexed by monitoring calls totruncate. When the indexing of all the shards is completed, ingesters transition to theDecommissionedstatus at which point they become safe to shut down.I also added a
OpenObservationStreamRPC to ingesters, so we can track the status of the decommissioning process. In the future, we can enrich theObservationMessageobject to track more things.How was this PR tested?