fix: Correct the percentile values passed to the percentile function in DescriptiveStats for the index describe command #4136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
6 tasks
|
Would you mind improving the |
|
@guilload am still figuring my way around the codebase, could you help point me in the right direction, I am assuming you mean add assertions that should catch similar errors in the future? |
guilload
approved these changes
Nov 14, 2023
|
You can run You can run cargo test --manifest-path quickwit/Cargo.toml -p quickwit-common to test a single crate. |
unpervertedkid
changed the title
|
@guilload Should be good now. |
|
Thanks @unpervertedkid ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR corrects the percentile values passed to the percentile function in the DescriptiveStats struct. Previously, the percentiles were incorrectly set as 1, 50, 50, 75, and 75. This PR changes these values to correctly represent the 1st, 25th, 50th, 75th, and 99th percentiles.
How was this PR tested?
This PR was tested by running the existing unit tests for the DescriptiveStats struct. Additionally, manual testing was performed by generating statistics for a sample dataset and verifying that the outputted percentiles were correct.
More assertions were added to prevent the same issue from recurring in the future.