Changing the shutdown logic for the rest server. #4173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmassot
reviewed
Nov 22, 2023
| .serve(Shared::new(service)) | ||
| .with_graceful_shutdown(shutdown_signal); | ||
|
|
||
| let serve_fut = async move { |
There was a problem hiding this comment.
I'm okay with this. Note that dropping the server will not prevent current connections from working (ref)
I would either add a comment there or open a low-priority issue on the REST server graceful shutdown.
There was a problem hiding this comment.
ah good point. I am not sure why but it did fix the test terminating after the rest clients issue.
fmassot
approved these changes
Nov 22, 2023
Instead of relying on the hyper graceful shutdown, which does not shutdown in the presence of existing http connections. Closes #4169
fulmicoton
force-pushed
the
issue/4169-force-shutdown
branch
from
f5714b4 to
52b06ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of relying on the hyper graceful shutdown, which does not shutdown in the presence of existing http connections.
Closes #4169