Allow $ and @ characters in field names. #4413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etolbakov
reviewed
Jan 17, 2024
fmassot
force-pushed
the
fmassot/allow-dollar-in-field-name
branch
from
c3d713b to
fd5744c
Compare
guilload
reviewed
Jan 17, 2024
fmassot
commented
Jan 17, 2024
| @@ -146,3 +146,5 @@ storage: | |||
| flavor: minio | |||
| endpoint: http://127.0.0.1:9000 | |||
| ``` | |||
|
|
|||
| Note: `default_index_root_uri` or index URIs do not include the endpoint, you should set it as a typical S3 path such as `s3://indexes`. | |||
There was a problem hiding this comment.
Just a minor addition in the doc as I saw 2 users making this mistake, that is setting the URI as s3://127.0.0.1:9000/indexes
fmassot
force-pushed
the
fmassot/allow-dollar-in-field-name
branch
from
8b2fd87 to
be328d6
Compare
guilload
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivated by
@as the first character of field names, I got the issue a few months ago for the@timestampfield