limit number of warn logs #4472
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PSeitz
force-pushed
the
limit_error_logs
branch
from
a200a5d to
54199b8
Compare
fulmicoton
reviewed
Jan 29, 2024
| "{}", | ||
| error | ||
| ); | ||
| let error_str = error.to_string(); |
There was a problem hiding this comment.
keying the hashmap on the string representation of the error is not a great idea. What if the error display name contains something dynamic? (like a docid or something)
There was a problem hiding this comment.
Then we would still have the 20 logs limit per minute
|
closing for #4483 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The limit is on the doc processor level and not shared currently
closes #4461