Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialize service errors in dedicated gRPC header instead message field #4678

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

guilload
Copy link
Member

@guilload guilload commented Mar 5, 2024

Description

  • Serialize service errors in dedicated gRPC header instead of message field
  • Capture some tonic transport errors in proper error variants
  • Clean up error variants

How was this PR tested?

  • Added unit tests

@guilload guilload force-pushed the guilload/channel-timeout branch 8 times, most recently from 19183a6 to 63279cf Compare March 6, 2024 16:58
@guilload guilload marked this pull request as ready for review March 6, 2024 16:59
@guilload guilload requested a review from fulmicoton March 6, 2024 16:59
@guilload guilload force-pushed the guilload/channel-timeout branch 6 times, most recently from 7f7b031 to bd8f962 Compare March 6, 2024 22:07
@guilload guilload linked an issue Mar 6, 2024 that may be closed by this pull request
@guilload guilload force-pushed the guilload/channel-timeout branch 2 times, most recently from 1255112 to d235f7b Compare March 7, 2024 15:29
@guilload guilload force-pushed the guilload/channel-timeout branch 2 times, most recently from 7697e98 to b2e538a Compare March 8, 2024 13:22
@guilload guilload force-pushed the guilload/channel-timeout branch from b2e538a to 1ec0d21 Compare March 8, 2024 13:29
@guilload guilload merged commit 9cc3311 into main Mar 8, 2024
4 checks passed
@guilload guilload deleted the guilload/channel-timeout branch March 8, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Channel timeout error is not properly deserialized
2 participants