Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

warn on index/source creation failure #4687

Merged
merged 2 commits into from
Mar 7, 2024
Merged

warn on index/source creation failure #4687

merged 2 commits into from
Mar 7, 2024

Conversation

trinity-1686a
Copy link
Contributor

Description

fix #4680

How was this PR tested?

tested by creating an invalid source:

2024-03-06T10:52:51.454Z  WARN quickwit_serve::index_api::rest_handler: failed to create source: invalid config: failed to parse YAML file: missing field `topic`

@trinity-1686a trinity-1686a requested a review from fulmicoton March 6, 2024 10:53
@trinity-1686a trinity-1686a enabled auto-merge (squash) March 7, 2024 14:18
@trinity-1686a trinity-1686a merged commit 1c8473c into main Mar 7, 2024
4 checks passed
@trinity-1686a trinity-1686a deleted the trinity/warn-source-creation branch March 7, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fulmicoton fulmicoton fulmicoton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lack of error log on create source error.
2 participants
@trinity-1686a @fulmicoton