Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove seed resolution validation #4688

Merged
merged 2 commits into from
Mar 7, 2024
Merged

Remove seed resolution validation #4688

merged 2 commits into from
Mar 7, 2024

Conversation

rdettai
Copy link
Collaborator

@rdettai rdettai commented Mar 6, 2024

Description

On ECS when using CloudMap the tasks register to the service DNS entries as they are started. This check might fail because the other peers haven't registered yet. But the the DNS-based discovery mechanism implemented in Chitchat would have built the cluster successfully.

How was this PR tested?

Describe how you tested this PR.

@rdettai rdettai self-assigned this Mar 6, 2024
Copy link
Collaborator Author

@rdettai rdettai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the original reason for this check?

@rdettai rdettai force-pushed the rm-seed-validation branch from 5499aab to d54479a Compare March 6, 2024 14:00
@guilload
Copy link
Member

guilload commented Mar 6, 2024

The check is here because downstream errors resulting from the inability to resolve peer seeds will not be as clear and easily understood. You will get metastore is unavailable or something like that, which can happen for a zillion reasons.

Please log a warning instead.

@rdettai
Copy link
Collaborator Author

rdettai commented Mar 6, 2024

We already have a warning for each unresolved host a few lines before:

if let Err(error) = peer_seed_addr.resolve().await {
warn!(peer_seed = %peer_seed_addr, error = ?error, "failed to resolve peer seed address");
continue;
}

Do you want an extra one when none of the seed hostnames were resolved?

@guilload
Copy link
Member

guilload commented Mar 6, 2024

Yes.

@rdettai rdettai enabled auto-merge (squash) March 7, 2024 08:06
@rdettai rdettai force-pushed the rm-seed-validation branch from 51ab03a to 0a88c16 Compare March 7, 2024 17:43
@rdettai rdettai merged commit cd96a3c into main Mar 7, 2024
4 checks passed
@rdettai rdettai deleted the rm-seed-validation branch March 7, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants