Open shards metrics was only updated on scale up/down. #4721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulmicoton
force-pushed
the
bug-open-shards-metrics-invalid
branch
2 times, most recently
from
339d9c4 to
82f7748
Compare
This PR also removes the source id label (as it will always be ingest v2). This is not much of a win since the overall metric cardinality does not change. It also removes `.all_shards_mut()` which was error-prone as a client could break all kinds of invariants.
fulmicoton
force-pushed
the
bug-open-shards-metrics-invalid
branch
from
82f7748 to
dbedc29
Compare
guilload
approved these changes
Mar 13, 2024
| @@ -513,6 +513,7 @@ impl Handler<DeleteIndexRequest> for ControlPlane { | |||
| ctx: &ActorContext<Self>, | |||
| ) -> Result<Self::Reply, ActorExitStatus> { | |||
| let index_uid: IndexUid = request.index_uid().clone(); | |||
| info!(index=%index_uid, "delete index"); | |||
There was a problem hiding this comment.
nit: add rather put those statements after the successful op.
| @@ -62,7 +62,7 @@ impl Default for ControlPlaneMetrics { | |||
| "Number of open shards per source.", | |||
There was a problem hiding this comment.
Suggested change
| "Number of open shards per source.", | |
| "Number of open shards per indexer.", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also removes the source id label (as it will always be ingest
v2). This is not much of a win since the overall metric cardinality does
not change.
It also removes
.all_shards_mut()which was error-proneas a client could break all kinds of invariants.