Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fetch timestamp in blocks #4770

Merged
merged 2 commits into from
Mar 22, 2024
Merged

fetch timestamp in blocks #4770

merged 2 commits into from
Mar 22, 2024

Conversation

PSeitz
Copy link
Contributor

@PSeitz PSeitz commented Mar 21, 2024 •
edited
Loading

comp_block_fetch

@fulmicoton
Copy link
Contributor

Does it help?

@PSeitz
Copy link
Contributor Author

PSeitz commented Mar 21, 2024 •
edited
Loading

Does it help?

Updated with benchmark numbers. On the range query yes, which is just a range filter on the timestamp. The rest is not really discernible from noise.

Overall it's a relative small gain. On larger queries spanning multiple splits, the filter can be removed on most queries since the time frame spans most of the splits completely and can be removed.

@PSeitz PSeitz requested a review from fulmicoton March 22, 2024 03:25
@PSeitz PSeitz enabled auto-merge (squash) March 22, 2024 07:51
@PSeitz PSeitz merged commit f509e0e into main Mar 22, 2024
4 checks passed
@PSeitz PSeitz deleted the faster_collect branch March 22, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fulmicoton fulmicoton fulmicoton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PSeitz @fulmicoton