Added latency metrics for REST endpoint. #4977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulmicoton
force-pushed
the
issue/4932-response-latency-metric
branch
4 times, most recently
from
dbaf32a to
9b08e84
Compare
This PR also makes it possible to set specific buckets for histograms. Cloes #4932
fulmicoton
force-pushed
the
issue/4932-response-latency-metric
branch
from
9b08e84 to
c540694
Compare
trinity-1686a
approved these changes
May 13, 2024
| @@ -40,6 +42,7 @@ impl Default for SearchMetrics { | |||
| "Number of seconds required to run a leaf search over a single split. The timer \ | |||
| starts after the semaphore is obtained.", | |||
| "search", | |||
| exponential_buckets(0.002, 2.0, 8).unwrap(), | |||
There was a problem hiding this comment.
last bucket ends at half a second. while i understand smaller steps for leaf_search_split, in my experience having some split being longer than that isn't necessarily rare. imo either the start bucket or the number of bucket needs to be increased
Comment on lines
39
to
40
| "request_duration_seconds", | ||
| "Response time in millisecs", |
There was a problem hiding this comment.
we use secs, not seconds, elsewhere.
the comment gives the wrong unit too
There was a problem hiding this comment.
good point. Yeah this is tricky. We used secs in all place but one (apart from here) and prometheus docs recommends seconds
There was a problem hiding this comment.
Ill switch to secs.
fulmicoton
force-pushed
the
issue/4932-response-latency-metric
branch
from
002c664 to
118a3b6
Compare
fulmicoton
added a commit
that referenced
this pull request
May 14, 2024
* Added latency metrics for REST endpoint. This PR also makes it possible to set specific buckets for histograms. Cloes #4932 * CR comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also makes it possible to set specific buckets for histograms.
Cloes #4932