Initiate node sizing docs #5018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilload
reviewed
May 22, 2024
guilload
approved these changes
May 22, 2024
There was a problem hiding this comment.
Looking good.
I'd add a warning "you mileage may vary blabla, use this guide to establish baseline and increase or decrease the resources depending on your workload."
I would remove the file-backed section and create a dedicated metastore section with two subsections one for the service and one for the database. Up to you.
In many setups, the Postgres config will be a bit separate from the QW cluster config (e.g they might have different lifecycles, so live in different terraform scripts). So I think its more readable for the typical ops user to have the sizing suggestions organized accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a doc entry to help users dimension their QW clusters.
How was this PR tested?
Describe how you tested this PR.