cast updated fields #5076
Merged
cast updated fields #5076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Make sure the motivation also ends up in the commit description. |
9 tasks
guilload
approved these changes
Jun 5, 2024
quickwit/quickwit-doc-mapper/src/default_doc_mapper/mapping_tree.rs
Outdated
Show resolved
Hide resolved
quickwit/quickwit-doc-mapper/src/default_doc_mapper/mapping_tree.rs
Outdated
Show resolved
Hide resolved
quickwit/quickwit-doc-mapper/src/default_doc_mapper/mapping_tree.rs
Outdated
Show resolved
Hide resolved
quickwit/quickwit-doc-mapper/src/default_doc_mapper/mapping_tree.rs
Outdated
Show resolved
Hide resolved
guilload
reviewed
Jun 5, 2024
quickwit/quickwit-doc-mapper/src/default_doc_mapper/mapping_tree.rs
Outdated
Show resolved
Hide resolved
guilload
approved these changes
Jun 6, 2024
quickwit/quickwit-doc-mapper/src/default_doc_mapper/mapping_tree.rs
Outdated
Show resolved
Hide resolved
quickwit/quickwit-doc-mapper/src/default_doc_mapper/mapping_tree.rs
Outdated
Show resolved
Hide resolved
|
|
||
| /// Transform a tantivy object into a serde_json one, without cloning strings. | ||
| /// It still allocates maps. | ||
| // TODO we should probably move this to tantivy, it has the opposite conversion already |
There was a problem hiding this comment.
@PSeitz, can we move that code to tantivy eventually?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following a docmapper update, we might end up with documents with a one type stored, while the docmapper expecting a different type, attempt to cast what we have to what we want.
How was this PR tested?
completed unit tests, tested manually after updating an index