Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index update from index config #5078

Merged
merged 10 commits into from
Jun 12, 2024
Merged

Index update from index config #5078

merged 10 commits into from
Jun 12, 2024

Conversation

rdettai
Copy link
Collaborator

@rdettai rdettai commented Jun 4, 2024

Description

  • Add the indexing settings to the update APIs
  • use the index config as input to the update cli and endpoint
  • docs

Note: I removed some ref to the deprecated max_merge_write_throughput here and there.

How was this PR tested?

Tested the example docs
Tested the swagger

@rdettai rdettai self-assigned this Jun 4, 2024
@rdettai rdettai mentioned this pull request Jun 4, 2024
Copy link

github-actions bot commented Jun 4, 2024

On SSD:

Average search latency is 1.0x that of the reference (lower is better).
Ref run id: 2041, ref commit: 82a00a7
Link

On GCS:

Average search latency is 1.14x that of the reference (lower is better).
Ref run id: 2042, ref commit: 82a00a7
Link

@rdettai rdettai force-pushed the index_update_v2 branch 4 times, most recently from 515c6d6 to 27645bc Compare June 5, 2024 14:33
@rdettai rdettai requested a review from guilload June 5, 2024 15:14
@rdettai
Copy link
Collaborator Author

rdettai commented Jun 5, 2024

Regarding the following TODO:

// TODO: Handle doc mapping and/or indexing settings update here.

My current understanding is that it should be addressed after #4928.

Copy link
Member

@guilload guilload left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In good shape.

docs/reference/rest-api.md Outdated Show resolved Hide resolved
docs/reference/rest-api.md Outdated Show resolved Hide resolved
docs/reference/rest-api.md Outdated Show resolved Hide resolved
docs/reference/rest-api.md Outdated Show resolved Hide resolved
docs/reference/rest-api.md Outdated Show resolved Hide resolved
quickwit/quickwit-metastore/src/tests/index.rs Outdated Show resolved Hide resolved
quickwit/quickwit-rest-client/src/rest_client.rs Outdated Show resolved Hide resolved
quickwit/quickwit-serve/src/index_api/rest_handler.rs Outdated Show resolved Hide resolved
quickwit/quickwit-serve/src/index_api/rest_handler.rs Outdated Show resolved Hide resolved
quickwit/quickwit-control-plane/src/model/mod.rs Outdated Show resolved Hide resolved
@rdettai rdettai force-pushed the index_update_v2 branch from 1d204bf to d6b9be6 Compare June 6, 2024 12:16
@rdettai rdettai force-pushed the index_update_v2 branch 2 times, most recently from 6d81f1f to 39f1d3b Compare June 7, 2024 13:33
@rdettai rdettai requested a review from guilload June 10, 2024 12:46
quickwit/quickwit-cli/src/index.rs Outdated Show resolved Hide resolved
quickwit/quickwit-cli/src/index.rs Outdated Show resolved Hide resolved
quickwit/quickwit-config/src/index_config/serialize.rs Outdated Show resolved Hide resolved
@rdettai rdettai enabled auto-merge (squash) June 12, 2024 07:47
@rdettai rdettai merged commit f27198f into main Jun 12, 2024
5 checks passed
@rdettai rdettai deleted the index_update_v2 branch June 12, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants