Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show queues_dir_path on failed create #5079

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

dholroyd
Copy link
Contributor

@dholroyd dholroyd commented Jun 4, 2024

Description

I needed to look at the code to work out that I had bad permissions on qwdata.

How was this PR tested?

Before,

thread 'main' panicked at /projects/quickwit/quickwit/quickwit-ingest/src/queue.rs:44:58:
called `Result::unwrap()` on an `Err` value: Os { code: 13, kind: PermissionDenied, message: "Permission denied" }

After,

✘ command failed: failed to start ingest v1 service

Caused by:
    0: failed to open the ingest API record log located at `/noperm/qwdata/queues`
    1: io error failed to create WAL directory `/noperm/qwdata/queues`: Permission denied (os error 13)

@CLAassistant
Copy link

CLAassistant commented Jun 4, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@guilload guilload left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arf, that unwrap was unfortunate... Please pick up my suggestion (you may have to fix the formatting (make fix), and I'll approve the PR.

quickwit/quickwit-ingest/src/queue.rs Outdated Show resolved Hide resolved
@dholroyd dholroyd force-pushed the report-queues-dir-path-err branch from 4eb3303 to 0c29057 Compare June 4, 2024 21:13
@fulmicoton
Copy link
Contributor

@dholroyd thank you for catching this!

@fulmicoton fulmicoton merged commit b57eb12 into quickwit-oss:main Jun 5, 2024
5 checks passed
@dholroyd dholroyd deleted the report-queues-dir-path-err branch June 7, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants