Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add doc mapping UID attribute to DocMapping #5087

Merged
merged 3 commits into from
Jun 19, 2024
Merged

Add doc mapping UID attribute to DocMapping #5087

merged 3 commits into from
Jun 19, 2024

Conversation

guilload
Copy link
Member

@guilload guilload commented Jun 5, 2024 •
edited
Loading

Description

Per title.

How was this PR tested?

Fixed and added backward compatibility tests.

@guilload guilload requested a review from trinity-1686a June 5, 2024 22:48
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 5, 2024 •
edited
Loading

On SSD:

Average search latency is 1.0x that of the reference (lower is better).
Ref run id: 1978, ref commit: fd4ae65
Link

On GCS:

Average search latency is 0.926x that of the reference (lower is better).
Ref run id: 1979, ref commit: fd4ae65
Link

Base automatically changed from guilload/refactor-doc-mapping/mapper-builder to main June 6, 2024 00:06
@guilload guilload force-pushed the guilload/add-doc-mapping-uid-attribute-to-doc-mapper branch 8 times, most recently from 8bce3a9 to f56ef8e Compare June 11, 2024 19:30
trinity-1686a
trinity-1686a approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@trinity-1686a trinity-1686a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just small questions

quickwit/quickwit-control-plane/src/control_plane.rs Show resolved Hide resolved
quickwit/quickwit-doc-mapper/src/doc_mapping.rs Show resolved Hide resolved
@guilload guilload force-pushed the guilload/add-doc-mapping-uid-attribute-to-doc-mapper branch from f56ef8e to c746786 Compare June 19, 2024 15:16
@guilload guilload force-pushed the guilload/add-doc-mapping-uid-attribute-to-doc-mapper branch from c746786 to 353c2e6 Compare June 19, 2024 15:20
@guilload guilload merged commit 5b85f7c into main Jun 19, 2024
4 of 5 checks passed
@guilload guilload deleted the guilload/add-doc-mapping-uid-attribute-to-doc-mapper branch June 19, 2024 15:56
@guilload guilload mentioned this pull request Jun 19, 2024
Closed
fulmicoton pushed a commit that referenced this pull request Jul 2, 2024
@guilload @fulmicoton
Add doc mapping UID attribute to DocMapping (#5087)
1687f6b 
* Add `doc_mapping_uid` field to `DocMapper`

* Bump config file format version

* Leave doc mapping UID out of doc mapping comparison
@trinity-1686a trinity-1686a mentioned this pull request Jul 12, 2024
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trinity-1686a trinity-1686a trinity-1686a approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guilload @trinity-1686a