Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take bool env var values into account instead of presence #5095

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

guilload
Copy link
Member

@guilload guilload commented Jun 7, 2024

Description

When the Airmail team modifies boolean environment variables, I don't know whether they actually remove them or update the values, so I'd be more comfortable shipping that PR before the next Airmail releases.

How was this PR tested?

  • Added unit test

@guilload guilload requested a review from trinity-1686a June 7, 2024 16:09
@guilload guilload force-pushed the guilload/parse-bool-str-lenient branch from 53cf59c to 41a2a60 Compare June 7, 2024 16:54
Copy link

github-actions bot commented Jun 7, 2024

On SSD:

Average search latency is 0.994x that of the reference (lower is better).
Ref run id: 1968, ref commit: 47caef0
Link

On GCS:

Average search latency is 1.03x that of the reference (lower is better).
Ref run id: 1969, ref commit: 47caef0
Link

Copy link
Contributor

@trinity-1686a trinity-1686a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i went through all std::env::var calls i could find. These 3 (lambda related) still parse boolean directly: ENABLE_VERBOSE_JSON_LOGS DISABLE_MERGE DISABLE_JANITOR

@guilload
Copy link
Member Author

Well spotted. I will fix those and merge the PR.

@guilload guilload force-pushed the guilload/parse-bool-str-lenient branch from 41a2a60 to 192ec81 Compare June 10, 2024 16:16
@guilload guilload merged commit fd4ae65 into main Jun 10, 2024
5 checks passed
@guilload guilload deleted the guilload/parse-bool-str-lenient branch June 10, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants