Refactor file source #5100
Closed
Refactor file source #5100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdettai
force-pushed
the
refactor-file-source
branch
from
eb6a8cf to
c9b594d
Compare
rdettai
force-pushed
the
refactor-file-source
branch
from
962decc to
008bfe3
Compare
rdettai
force-pushed
the
refactor-file-source
branch
from
008bfe3 to
373435a
Compare
rdettai
force-pushed
the
refactor-file-source
branch
from
373435a to
afd7868
Compare
rdettai
force-pushed
the
refactor-file-source
branch
6 times, most recently
from
fdc98a5 to
3555d3a
Compare
fulmicoton
reviewed
Jun 14, 2024
fulmicoton
reviewed
Jun 14, 2024
fulmicoton
reviewed
Jun 14, 2024
rdettai
force-pushed
the
refactor-file-source
branch
from
94f94ee to
bea5d82
Compare
rdettai
force-pushed
the
refactor-file-source
branch
from
bea5d82 to
6d6fdb1
Compare
|
Closing this in favor of #5148 that brings significant changes on top of the file source, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To prepare the S3 backed SQS source, this PR refactors the file source so that generates
RawDocBatchcan be reused.How was this PR tested?
Added extra unit tests to the new DocFileReader.