5117 disable per index metrics #5125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulmicoton
force-pushed
the
5117-disable-per-index-metrics
branch
2 times, most recently
from
670e7cd to
365f706
Compare
fulmicoton
force-pushed
the
5117-disable-per-index-metrics
branch
2 times, most recently
from
c65adee to
ab4e806
Compare
fulmicoton
force-pushed
the
5117-disable-per-index-metrics
branch
2 times, most recently
from
fb373f4 to
cd6594b
Compare
variable. By default they are enabled. If the `PER_INDEX_METRICS_ENABLED` environment variable is set to false, then all of the index metrics are grouped under the index_id `__any__`. In addition, this PR refactors a little bit the way we handled the docprocessor metrics. We now cache the docprocessor counters, hence preventing 1 hash lookup per document.
fulmicoton
force-pushed
the
5117-disable-per-index-metrics
branch
from
cd6594b to
1e0e2fa
Compare
guilload
approved these changes
Jun 14, 2024
| @@ -395,7 +432,7 @@ impl DocProcessor { | |||
| if cfg!(not(feature = "vrl")) && transform_config_opt.is_some() { | |||
| bail!("VRL is not enabled: please recompile with the `vrl` feature") | |||
| } | |||
| let doc_processor = Self { | |||
| Ok(DocProcessor { | |||
There was a problem hiding this comment.
Do you want me to edit the contribution guidelines and prohibit Self? :D
Co-authored-by: Adrien Guillo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.