Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use nextest in Makefile #5158

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Use nextest in Makefile #5158

merged 2 commits into from
Jun 26, 2024

Conversation

rdettai
Copy link
Contributor

@rdettai rdettai commented Jun 25, 2024

Description

We use nextest in the CI to stabilize tests. This PR changes the Makefile to also use nextest.

How was this PR tested?

Ran make test-all

@github-actions GitHub Actions
Copy link

On SSD:

Average search latency is 0.996x that of the reference (lower is better).
Ref run id: 2268, ref commit: 9fddb68
Link

On GCS:

Average search latency is 1.08x that of the reference (lower is better).
Ref run id: 2269, ref commit: 9fddb68
Link

guilload
guilload approved these changes Jun 25, 2024
View reviewed changes
quickwit/Makefile Outdated Show resolved Hide resolved
@rdettai rdettai enabled auto-merge (squash) June 26, 2024 07:41
@rdettai rdettai merged commit 4ade7b5 into main Jun 26, 2024
4 of 5 checks passed
@rdettai rdettai deleted the make-nextest branch June 26, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guilload guilload guilload approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rdettai @guilload