Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply rate limiting before validating docs #5170

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

guilload
Copy link
Member

Description

Check WAL capacity and apply rate limiting before validating docs.

How was this PR tested?

Added unit tests

@guilload guilload requested a review from fulmicoton June 26, 2024 12:44
@guilload guilload linked an issue Jun 26, 2024 that may be closed by this pull request
Copy link

On SSD:

Average search latency is 1.0x that of the reference (lower is better).
Ref run id: 2337, ref commit: 4ade7b5
Link

On GCS:

Average search latency is 1.03x that of the reference (lower is better).
Ref run id: 2339, ref commit: 4ade7b5
Link

@fulmicoton fulmicoton merged commit b54d8f2 into main Jun 27, 2024
5 checks passed
@fulmicoton fulmicoton deleted the guilload/apply-rate-limiting-before-doc-validation branch June 27, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enforce shard rate limiting before validating documents
2 participants