Optimize json parsing for validation #5181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulmicoton
force-pushed
the
optimize-json-parse
branch
from
fe4e904 to
034839d
Compare
PSeitz
reviewed
Jul 2, 2024
| Ok(()) | ||
| } else { | ||
| Err(format!( | ||
| "failed to parse datetime `{:?}`: value is larger than i64::MAX", |
There was a problem hiding this comment.
this code is unreachable since as_f64 always succeeds
There was a problem hiding this comment.
I can't unwrap though, always returning Some is an implementation detail of serde_borrow_json. I'll change the error message.
PSeitz
reviewed
Jul 2, 2024
quickwit/quickwit-doc-mapper/src/default_doc_mapper/field_mapping_entry.rs
Show resolved
Hide resolved
PSeitz
reviewed
Jul 2, 2024
This uses serde_json_borrow to avoid most allocation, copying, and inserting in hashmap as we deserialize documents. Before: validation is taking 10.25% of the CPU After validation is taking 5.9% of the CPU.
fulmicoton
force-pushed
the
optimize-json-parse
branch
from
ab1d19f to
5e0062c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.