add api endpoint to get query ast #5212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulmicoton
reviewed
Jul 15, 2024
| quickwit_ast: request_metadata.query_ast_resolved, | ||
| tantivy_ast: format!("{query:#?}"), | ||
| searched_splits: split_ids, | ||
| storage_requests: StorageRequestCount { |
There was a problem hiding this comment.
that's cool you extended the thing to a warmup info etc! can we actually get the number of bytes as well?
There was a problem hiding this comment.
that's something i would find interesting too, but right now it's not as easy to get. All metadata we get here, we get only through the metastore, with zero call to the storage. To get more, we would need to actually download things from storage, which starts having more of a EXPLAIN ANALYSE than an EXPLAIN semantic. I think that should be left out of scope of this PR, but let's open a ticket so eventually people can pass ?analyze=true or something to get that information as well
fulmicoton
reviewed
Jul 15, 2024
fulmicoton
reviewed
Jul 15, 2024
trinity-1686a
force-pushed
the
trinity/get-query-ast
branch
from
6c17624 to
c750349
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix #5190
add api endpoint to get the quickwit and tantivy ast for a query, as well as what splits would be hit (taking into account time range and tags), and how many/what kind of storage request are to be expected for each split
How was this PR tested?
tested manually plus added basic unit test