[for analysis] Not working airmail #5217
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* also remove hits that are too many when removing skiped hits * add mock-test
…ith Glasskube (#5071) Signed-off-by: Idriss Neumann <[email protected]>
* Further optimization of validation. This uses serde_json_borrow to avoid most allocation, copying, and inserting in hashmap as we deserialize documents. Before: validation is taking 10.25% of the CPU After validation is taking 5.9% of the CPU. * CR comment. changed error message
includes cardinality aggregation and term aggregation perf improvement for large "size" parameters
The piece that estimates whether the next request is likely to fail is extremely simplistic for the moment. It simply counter the number of errors (not taking in account successes) that happened in a given time window. The reason is that for the moment, we want to use it for persist requests when the WAL is full. On airmail, the aggressive retry logic of the client was causing a massive grpc storm on the faulty indexer node, taking all of its CPU and preventing it from getting out of that state. In this case, the error estimation logic is very simple, a full WAL guarantees that no further persist request will be successful for a little while.
* docs: using-vector.md: Adjust Vector remap configuration to silence errors/warnings * docs: using-vector.md: Provide a link to the index configuration code so it doesn't go out of sync
* optimize topn requests add logic to detect which splits will deliver the top n results for requests. This is only supported for match_all requests, with optional sort_by on timestamp sorting. start_timestamp, end_timestamp as well as a filter on the timestamp field is not supported currently but could be. * move to function, refactor
* Using the shard throughput information in the scheduling logic. * added cli flags
…5198) Bumps [certifi](https://github.com/certifi/python-certifi) from 2024.2.2 to 2024.7.4. - [Commits](certifi/python-certifi@2024.02.02...2024.07.04) --- updated-dependencies: - dependency-name: certifi dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
throughput. Scaling up relies on the short term average in order to rapidly react to a change in throughput, while scaling down and the indexing scheduler relies on the long term average.
fulmicoton
commented
Jul 12, 2024
| @@ -8112,7 +8134,7 @@ dependencies = [ | |||
| [[package]] | |||
| name = "tantivy" | |||
| version = "0.23.0" | |||
| source = "git+https://github.com/quickwit-oss/tantivy/?rev=08b9fc0#08b9fc0b3114640ad06c2358c404c474a9eea3c1" | |||
| source = "git+https://github.com/quickwit-oss/tantivy/?rev=13e9885#13e9885dfda8cebf4bfef72f53bf811da8549445" | |||
There was a problem hiding this comment.
tantivy difference?
fulmicoton
commented
Jul 12, 2024
| @@ -324,7 +325,7 @@ quickwit-serve = { path = "quickwit-serve" } | |||
| quickwit-storage = { path = "quickwit-storage" } | |||
| quickwit-telemetry = { path = "quickwit-telemetry" } | |||
|
|
|||
| tantivy = { git = "https://github.com/quickwit-oss/tantivy/", rev = "08b9fc0", default-features = false, features = [ | |||
| tantivy = { git = "https://github.com/quickwit-oss/tantivy/", rev = "13e9885", default-features = false, features = [ | |||
There was a problem hiding this comment.
tantivy version is changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.