Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix source path in Lambda distrib #5327

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Fix source path in Lambda distrib #5327

merged 2 commits into from
Aug 20, 2024

Conversation

rdettai
Copy link
Contributor

@rdettai rdettai commented Aug 19, 2024

Description

Bug introduced by #5148

Also removed the overwrite option which was hardcoded and buggy anyway.

How was this PR tested?

Added an end 2 end integration test exposed in the Makefile. Note that the test is currently failing until #5330 is also merged.

@rdettai rdettai self-assigned this Aug 19, 2024
@rdettai rdettai marked this pull request as ready for review August 19, 2024 14:11
@rdettai rdettai requested a review from trinity-1686a August 19, 2024 14:11
@rdettai
Copy link
Contributor Author

rdettai commented Aug 19, 2024

Copy link

github-actions bot commented Aug 19, 2024

On SSD:

Average search latency is 1.01x that of the reference (lower is better).
Ref run id: 2894, ref commit: c59be63
Link

On GCS:

Average search latency is 1.02x that of the reference (lower is better).
Ref run id: 2895, ref commit: c59be63
Link

@rdettai rdettai force-pushed the fix-lambda-path branch 3 times, most recently from e3e6eac to 99804bd Compare August 20, 2024 12:07
@rdettai rdettai enabled auto-merge (squash) August 20, 2024 12:08
@rdettai rdettai merged commit 5d7a549 into main Aug 20, 2024
5 checks passed
@rdettai rdettai deleted the fix-lambda-path branch August 20, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants