Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support concatenated field as default search field #5331

Merged
merged 3 commits into from
Aug 21, 2024
Merged

support concatenated field as default search field #5331

merged 3 commits into from
Aug 21, 2024

Conversation

trinity-1686a
Copy link
Contributor

Description

fix using concatenate field as default search field

How was this PR tested?

added unit test

@trinity-1686a trinity-1686a requested a review from rdettai August 20, 2024 12:18
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 20, 2024 •
edited
Loading

On SSD:

Average search latency is 0.999x that of the reference (lower is better).
Ref run id: 2904, ref commit: 108ad21
Link

On GCS:

Average search latency is 1.05x that of the reference (lower is better).
Ref run id: 2905, ref commit: 108ad21
Link

@trinity-1686a trinity-1686a enabled auto-merge (squash) August 21, 2024 08:40
@trinity-1686a trinity-1686a merged commit dcfab3c into main Aug 21, 2024
5 checks passed
@trinity-1686a trinity-1686a deleted the trinity/allow-concat-default-field branch August 21, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdettai rdettai rdettai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trinity-1686a @rdettai