Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix warming-up position incorrectly when 2 phrase prefix query are issued for the same final term #5336

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

trinity-1686a
Copy link
Contributor

Description

fix a bug where field:"short"* field:"not short"* would succeed, but field:"not short"* field:"short"* would fail to load position, and return an error

How was this PR tested?

tested manually, added unit test for the faulty code

@trinity-1686a trinity-1686a requested a review from fmassot August 22, 2024 13:50
Copy link

On SSD:

Average search latency is 0.996x that of the reference (lower is better).
Ref run id: 2929, ref commit: 995bb62
Link

On GCS:

Average search latency is 0.998x that of the reference (lower is better).
Ref run id: 2930, ref commit: 995bb62
Link

Copy link
Contributor

@fmassot fmassot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!!!!!

@trinity-1686a trinity-1686a merged commit a8a3960 into main Aug 22, 2024
5 checks passed
@trinity-1686a trinity-1686a deleted the trinity/fix-missing-warmup-position branch August 22, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants