Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename index-id to hopefully fix coverage #5337

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Conversation

trinity-1686a
Copy link
Contributor

two test had the same index-id, which is my best guess as to why CI is currently red on main

@trinity-1686a trinity-1686a requested a review from rdettai August 22, 2024 16:22
Copy link

github-actions bot commented Aug 22, 2024

On SSD:

Average search latency is 0.998x that of the reference (lower is better).
Ref run id: 2963, ref commit: 82c475b
Link

On GCS:

Average search latency is 0.967x that of the reference (lower is better).
Ref run id: 2964, ref commit: 82c475b
Link

@rdettai rdettai enabled auto-merge (rebase) August 23, 2024 07:11
@rdettai rdettai disabled auto-merge August 23, 2024 07:24
@rdettai rdettai force-pushed the trinity/fix-ci-coverage branch from eac9e8a to fd9f8dc Compare August 23, 2024 07:24
@rdettai rdettai enabled auto-merge (squash) August 23, 2024 07:24
@rdettai
Copy link
Contributor

rdettai commented Aug 23, 2024

🙏

@rdettai
Copy link
Contributor

rdettai commented Aug 23, 2024

I didn´t find the CI run where this was an issue, but fixing the typo doesn´t hurt 😄

@rdettai rdettai merged commit d9577ba into main Aug 23, 2024
5 checks passed
@rdettai rdettai deleted the trinity/fix-ci-coverage branch August 23, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants