Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wait_for commit on ingest V2 #5359

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Fix wait_for commit on ingest V2 #5359

merged 2 commits into from
Aug 28, 2024

Conversation

rdettai
Copy link
Contributor

@rdettai rdettai commented Aug 28, 2024

Description

Closes #5351

How was this PR tested?

Describe how you tested this PR.

@rdettai rdettai linked an issue Aug 28, 2024 that may be closed by this pull request
Ingest V2 misses commit wait_for #5351
Closed
@rdettai
Copy link
Contributor Author

rdettai commented Aug 28, 2024

Merging this to upstream branch because commit=force also requires to wait (see docs

@rdettai rdettai merged commit 5c1e3da into fix-commit-force Aug 28, 2024
5 checks passed
@rdettai rdettai deleted the fix-commit-wait-for branch August 28, 2024 15:53
@github-actions GitHub Actions
Copy link

On SSD:

Average search latency is 1.01x that of the reference (lower is better).
Ref run id: 3009, ref commit: e3927eb
Link

On GCS:

Average search latency is 1.01x that of the reference (lower is better).
Ref run id: 3010, ref commit: e3927eb
Link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ingest V2 misses commit wait_for
1 participant
@rdettai