Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default timestamps in OTEL logs #5366

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Change default timestamps in OTEL logs #5366

merged 2 commits into from
Sep 5, 2024

Conversation

rdettai
Copy link
Collaborator

@rdettai rdettai commented Aug 29, 2024

Description

Closes #5311

How was this PR tested?

Describe how you tested this PR.

@rdettai rdettai self-assigned this Aug 29, 2024
@rdettai rdettai requested a review from fmassot August 29, 2024 14:26
@rdettai rdettai force-pushed the otel-logs-default-ts branch from 1d24462 to df84179 Compare August 29, 2024 14:36
Copy link

github-actions bot commented Aug 29, 2024

On SSD:

Average search latency is 1.01x that of the reference (lower is better).
Ref run id: 3248, ref commit: 80364dd
Link

On GCS:

Average search latency is 1.02x that of the reference (lower is better).
Ref run id: 3249, ref commit: 80364dd
Link

@rdettai rdettai force-pushed the otel-logs-default-ts branch from 7b44f05 to b8540e6 Compare September 5, 2024 09:50
@rdettai rdettai enabled auto-merge (squash) September 5, 2024 09:50
@rdettai rdettai merged commit 1900197 into main Sep 5, 2024
5 checks passed
@rdettai rdettai deleted the otel-logs-default-ts branch September 5, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[otel log] Handle logs without Timestamp field better.
2 participants