fix jaeger http endpoint #5378
Merged
fix jaeger http endpoint #5378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix a bug with jaeger search api returning all root span instead of matching ones.
The query was modified to be
Must(is_root) Should(TraceId1) Should(TraceId2)..., which sounds like it limits more than just Shoulds would, but actually it means the Should only count for scoring (which we are not doing). What we ought to do isMust(is_root) Must(Should(TraceId1) Should(TraceId2)...)(must be root, and must match one of the trace id)