-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ES API compatible date time parsers #5461
Conversation
a1eae0f
to
adb8152
Compare
ES uses [own names][1] for date formats. I implemented the ones that I was able to find in OSD. Test cases taken from [doc][1] and [OS test][2]. This PR is fixing [issue](#5460) and restore compatibility with OSD. [1]: https://opensearch.org/docs/latest/field-types/supported-field-types/date/ [2]: https://github.com/opensearch-project/OpenSearch/blob/main/server/src/test/java/org/opensearch/common/time/DateFormattersTests.java
adb8152
to
113eaee
Compare
@kuzaxak you might be interested in checking this related PR. As far as I understand Paul’s idea was to enable the support using a regexset Maybe we can finalize it |
Okay, I missed it. Do you have plans to finish it? Or maybe I can help you? I can patch requests on the fly if implementation takes longer than a week. |
Closing as #5248 should be a generic solution instead of a partial one presented in this PR. |
I was curious to work on that just for sake of learning, so don’t have any sticky timelines. If you can proceed/ take a lead on this PR I think it will be great! |
I can. What is left to be done there? I see that you added some commented-out tests. Does it mean we need to implement Logix to make them work? And I think |
I added a bit more tests for I also see that "cargo nexttest" step is failing. |
Description
ES uses own names for date formats. I implemented the ones that I was able to find in OSD.
Test cases taken from doc and OS test.
This PR is fixing issue and restore compatibility with OSD.
How was this PR tested?
Added unit tests to cover new parsers.