refactor doc mapper #5522
Merged
refactor doc mapper #5522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PSeitz
force-pushed
the
refactor_mapping
branch
from
c09d328 to
33d10fa
Compare
move tantivy val to json to own module remove duplicated conversion logic move field_presence to own module
PSeitz
force-pushed
the
refactor_mapping
branch
from
33d10fa to
9525d50
Compare
fulmicoton
reviewed
Oct 24, 2024
| TantivyValue::Object(object) => tantivy_object_to_json_value(object), | ||
| // we shouldn't have these types inside a json field in quickwit | ||
| TantivyValue::PreTokStr(pretok) => JsonValue::String(pretok.text), | ||
| TantivyValue::Date(date) => quickwit_datetime::DateTimeOutputFormat::Rfc3339 |
There was a problem hiding this comment.
This is not what was done before. (this is better)
fulmicoton
reviewed
Oct 24, 2024
quickwit/quickwit-doc-mapper/src/doc_mapper/tantivy_val_to_json.rs
Outdated
Show resolved
Hide resolved
fulmicoton
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move tantivy val to json to own module
remove duplicated conversion logic
move field_presence to own module