doc mapper: convert number handling to deserialization #5527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PSeitz
force-pushed
the
refactor_mapping
branch
2 times, most recently
from
8f49c91 to
6192fbe
Compare
change number deserialization in docmapper from json to generic deserialization. This improves codes reuse between different code paths, e.g. serialization and validation.
PSeitz
force-pushed
the
refactor_mapping
branch
from
6192fbe to
eec22c9
Compare
fulmicoton
reviewed
Oct 29, 2024
|
|
||
| use super::*; | ||
|
|
||
| #[test] |
There was a problem hiding this comment.
we need to test what happens for stuff that is out of bound.
- "-1" to u64
- u64::MAX to i64
- 1.2 to u64
- "1.2" to u64
fulmicoton
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change number deserialization in docmapper from json to generic deserialization.
This improves codes reuse between different code paths, e.g.
serialization and validation.
fixes conversion order in
map_primitive_json_to_tantivy