Fix existence queries for nested fields #5581
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulmicoton
reviewed
Dec 11, 2024
| expected: | ||
| hits: | ||
| total: | ||
| # one of the docs contains `"payload":{}` |
There was a problem hiding this comment.
did you run this test against elasticsearch too locally?
There was a problem hiding this comment.
in particular is {} considered not having the value? Is this true in elastic and in quickwit? Both for fast field and indexed field path?
There was a problem hiding this comment.
yes, I ran this test against Elastic. That's how I got the 99 value and discovered that there is a {} and that it is considered has not having a value in Elastic
There was a problem hiding this comment.
I thnk you are the first dev to actually run those tests against elastic too :) thx
rdettai
force-pushed
the
nested-field-presence
branch
2 times, most recently
from
2efa1ed to
b986963
Compare
rdettai
force-pushed
the
nested-field-presence
branch
from
b986963 to
749f03b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #5560
How was this PR tested?
Describe how you tested this PR.