remove Document: DocumentDeserialize dependency #3319
Triggered via pull request
October 12, 2023 09:22
PSeitz
Status
Success
Total duration
1h 1m 55s
Artifacts
–
This run and associated checks have been archived and are scheduled for deletion.
Learn more about checks retention
Annotations
6 warnings
|
an array of `Range` that is only one element:
src/snippet/mod.rs#L693
warning: an array of `Range` that is only one element
--> src/snippet/mod.rs:693:66
|
693 | assert_eq!(&collapse_overlapped_ranges(&[0..3, 1..2,]), &[0..3]);
| ^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_range_in_vec_init
help: if you wanted a `Vec` that contains the entire range, try
|
693 | assert_eq!(&collapse_overlapped_ranges(&[0..3, 1..2,]), &(0..3).collect::<std::vec::Vec<usize>>());
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
help: if you wanted an array of len 3, try
|
693 | assert_eq!(&collapse_overlapped_ranges(&[0..3, 1..2,]), &[0; 3]);
| ~~~~
|
|
an array of `Range` that is only one element:
src/snippet/mod.rs#L692
warning: an array of `Range` that is only one element
--> src/snippet/mod.rs:692:66
|
692 | assert_eq!(&collapse_overlapped_ranges(&[0..2, 1..3,]), &[0..3]);
| ^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_range_in_vec_init
help: if you wanted a `Vec` that contains the entire range, try
|
692 | assert_eq!(&collapse_overlapped_ranges(&[0..2, 1..3,]), &(0..3).collect::<std::vec::Vec<usize>>());
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
help: if you wanted an array of len 3, try
|
692 | assert_eq!(&collapse_overlapped_ranges(&[0..2, 1..3,]), &[0; 3]);
| ~~~~
|
|
an array of `Range` that is only one element:
src/snippet/mod.rs#L691
warning: an array of `Range` that is only one element
--> src/snippet/mod.rs:691:66
|
691 | assert_eq!(&collapse_overlapped_ranges(&[0..2, 1..2,]), &[0..2]);
| ^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_range_in_vec_init
= note: `#[warn(clippy::single_range_in_vec_init)]` on by default
help: if you wanted a `Vec` that contains the entire range, try
|
691 | assert_eq!(&collapse_overlapped_ranges(&[0..2, 1..2,]), &(0..2).collect::<std::vec::Vec<usize>>());
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
help: if you wanted an array of len 2, try
|
691 | assert_eq!(&collapse_overlapped_ranges(&[0..2, 1..2,]), &[0; 2]);
| ~~~~
|
|
manual check for common ascii range:
src/schema/document/owned_value.rs#L369
warning: manual check for common ascii range
--> src/schema/document/owned_value.rs:369:12
|
369 | if (b'0'..=b'9').contains(&first_byte) {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `first_byte.is_ascii_digit()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_ascii_check
= note: `#[warn(clippy::manual_is_ascii_check)]` on by default
|
|
useless conversion to the same type: `bool`:
src/schema/document/existing_type_impls.rs#L80
warning: useless conversion to the same type: `bool`
--> src/schema/document/existing_type_impls.rs:80:44
|
80 | Ok(serde_json::Value::Bool(val.into()))
| ^^^^^^^^^^ help: consider removing `.into()`: `val`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` on by default
|
|
unused import: `Document`:
src/core/searcher.rs#L8
warning: unused import: `Document`
--> src/core/searcher.rs:8:31
|
8 | use crate::schema::document::{Document, DocumentDeserialize};
| ^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|